Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset filter parameters reset on unselect #6255

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Asset filter parameters reset on unselect #6255

merged 1 commit into from
Sep 11, 2023

Conversation

print-Sathvik
Copy link
Contributor

@print-Sathvik print-Sathvik commented Sep 9, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 062e9b1

Fixed a bug in AssetFilter component that caused API request to fail when some filters were not selected. Added nullish coalescing operators to asset_type, asset_class, and status properties of the data object in src/Components/Assets/AssetFilter.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 062e9b1

  • Add nullish coalescing operators to asset filter properties (link)

@print-Sathvik print-Sathvik requested a review from a team September 9, 2023 13:45
@print-Sathvik print-Sathvik requested a review from a team as a code owner September 9, 2023 13:45
@vercel
Copy link

vercel bot commented Sep 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2023 1:45pm

@netlify
Copy link

netlify bot commented Sep 9, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 062e9b1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64fc76df82a4de00084fc855
😎 Deploy Preview https://deploy-preview-6255--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, ideally the updateFilters method from useFilters hook should be updated instead to handle the removal of filters with value as undefined

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit baecaab into ohcnetwork:develop Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset filter parameters use undefined on unselecting
4 participants
@print-Sathvik @nihal467 @rithviknishad @khavinshankar